Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Backchannel validation to its own file and set of functions #471

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

avillega
Copy link
Contributor

No description provided.

@avillega avillega requested a review from dfarr November 22, 2024 01:37
updatedModel.tasks.set(req.bc.Task.Id, req.bc.Task)
updatedModel, err := d.BcStep(model, req)
if err != nil {
fmt.Println(err.Error())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 27.08333% with 35 lines in your changes missing coverage. Please review.

Project coverage is 55.25%. Comparing base (2abb735) to head (1cb940d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/dst/bc_validator.go 19.35% 25 Missing ⚠️
test/dst/dst.go 41.17% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   55.30%   55.25%   -0.05%     
==========================================
  Files         119      120       +1     
  Lines       13876    13906      +30     
==========================================
+ Hits         7674     7684      +10     
- Misses       5734     5754      +20     
  Partials      468      468              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@avillega avillega merged commit 16d3a16 into main Nov 22, 2024
3 of 6 checks passed
@avillega avillega deleted the avillega/move-bc-validation-to-file branch November 22, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants