Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avillega/deduplicate callbacks #478

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Conversation

avillega
Copy link
Contributor

@avillega avillega commented Dec 9, 2024

No description provided.

@avillega avillega requested a review from dfarr December 9, 2024 22:15
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 77.30871% with 86 lines in your changes missing coverage. Please review.

Project coverage is 56.85%. Comparing base (95c4887) to head (b6b4d56).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/subsystems/api/grpc/pb/promise.pb.go 83.11% 11 Missing and 2 partials ⚠️
...ternal/app/subsystems/api/grpc/pb/callback_t.pb.go 7.69% 9 Missing and 3 partials ⚠️
test/dst/validator.go 52.00% 9 Missing and 3 partials ⚠️
...rnal/app/subsystems/aio/store/postgres/postgres.go 50.00% 5 Missing and 3 partials ⚠️
...nternal/app/subsystems/api/grpc/pb/promise_t.pb.go 25.00% 6 Missing ⚠️
internal/app/subsystems/api/grpc/pb/task.pb.go 81.25% 6 Missing ⚠️
internal/app/subsystems/api/grpc/pb/callback.pb.go 61.53% 5 Missing ⚠️
...nal/app/subsystems/api/grpc/pb/callback_grpc.pb.go 60.00% 3 Missing and 1 partial ⚠️
...nternal/app/subsystems/api/grpc/pb/lock_grpc.pb.go 71.42% 3 Missing and 1 partial ⚠️
...rnal/app/subsystems/api/grpc/pb/promise_grpc.pb.go 83.33% 3 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
+ Coverage   54.91%   56.85%   +1.93%     
==========================================
  Files         120      120              
  Lines       13963    13479     -484     
==========================================
- Hits         7668     7663       -5     
+ Misses       5822     5345     -477     
+ Partials      473      471       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avillega avillega merged commit 1f1a419 into main Dec 10, 2024
29 checks passed
@avillega avillega deleted the avillega/deduplicate-callbacks branch December 10, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants