Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CreatePromiseAndCallback request #488

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

avillega
Copy link
Contributor

@avillega avillega commented Dec 12, 2024

Remove the createPromiseAndCallback request and its associated coroutine

@avillega avillega requested a review from dfarr December 12, 2024 23:48
@avillega
Copy link
Contributor Author

This one does not include the change to createPromiseAndTask yet, that will come in a future PR

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 56.78%. Comparing base (df87918) to head (7faf2ab).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/subsystems/api/grpc/pb/promise.pb.go 68.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   56.76%   56.78%   +0.02%     
==========================================
  Files         120      120              
  Lines       13479    13168     -311     
==========================================
- Hits         7651     7478     -173     
+ Misses       5355     5237     -118     
+ Partials      473      453      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avillega avillega merged commit cc53141 into main Dec 13, 2024
6 checks passed
@avillega avillega deleted the avillega/remove-create-promise-and-callback branch December 13, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants