Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]: Resolve string receiver in sender subsystem (#467) #495

Merged
merged 5 commits into from
Dec 17, 2024

Conversation

TusharMohapatra07
Copy link
Contributor

@TusharMohapatra07 TusharMohapatra07 commented Dec 14, 2024

Fixes #467

  • I've added the schemeToRecv function to sender subsystem.
  • Removed schemeToRecv from router subsystem.

@TusharMohapatra07
Copy link
Contributor Author

cc: @flossypurse @dfarr

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 56.81%. Comparing base (cc53141) to head (7eb3de4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/subsystems/aio/sender/sender.go 0.00% 28 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #495      +/-   ##
==========================================
- Coverage   56.84%   56.81%   -0.03%     
==========================================
  Files         120      120              
  Lines       13168    13171       +3     
==========================================
- Hits         7485     7483       -2     
- Misses       5230     5237       +7     
+ Partials      453      451       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TusharMohapatra07 TusharMohapatra07 changed the title [fix]: Resolve string receiver in sender subsystem (#467)[WIP] [fix]: Resolve string receiver in sender subsystem (#467) Dec 17, 2024
Copy link
Member

@dfarr dfarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@TusharMohapatra07
Copy link
Contributor Author

@dfarr Thanks for the approval! 😁

@dfarr dfarr merged commit 9e066cd into resonatehq:main Dec 17, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve string receiver in sender subsystem
2 participants