Log non linearizable path when linearization check fails #498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to anishathalye/porcupine#21 we can grab the longest linearizable path plus one additional operation (the first op that is not part of the linearizable path chronologically) to reproduce our DST logs including the error message. This information was lost in previous implementations of DST with porcupine.
When linearization fails, there may be multiple linearizable paths and multiple possible next operations. This implementation grabs the first non-linearizable path and the first possible next operation so the log is a "best effort" and should be taken with a grain of salt. As such the additional logs can be accessed behind the verbose flag.