Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad ids with zeros to help with lexographical ordering in dst #511

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

dfarr
Copy link
Member

@dfarr dfarr commented Jan 8, 2025

Resolves #508
Resolves #507

Tasks are retrieved from the database with an ORDER BY root_promise_id, id clause, unfortuantely there are slight discrepancies between sqlite and postgres ordering

postgres

root_promise_id id
s13.900000 36
s1.720000 35

sqlite

root_promise_id id
s1.720000 35
s13.900000 36

sqlite has the expected ordering, so I'm not sure what's going on with postgres. To sidestep this issue altogether I opted to pad all ids in DST with a sufficient number of zeros.

@dfarr dfarr requested a review from avillega January 8, 2025 01:05
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.14%. Comparing base (f8b8f36) to head (661ee56).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #511      +/-   ##
==========================================
- Coverage   56.17%   56.14%   -0.04%     
==========================================
  Files         122      122              
  Lines       13336    13340       +4     
==========================================
- Hits         7492     7490       -2     
- Misses       5393     5397       +4     
- Partials      451      453       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr dfarr merged commit eba2e6a into main Jan 9, 2025
52 checks passed
@dfarr dfarr deleted the fix/dst-task-sorting branch January 9, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DST: 14931 DST: 11503
2 participants