Add notifications api

[avillega]

No description provided.

[avillega]

This is not fully ready yet, but most of the implementation is done, still need to write all the tests and make sure this fully works, but would be nice to get early feedback.

[codecov]

Codecov Report

Attention: Patch coverage is 24.00722% with 421 lines in your changes missing coverage. Please review.

Project coverage is 54.94%. Comparing base (89c1a45) to head (13485da).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/app/coroutines/createNotify.go	0.00%	116 Missing ⚠️
cmd/notify/create.go	0.00%	62 Missing ⚠️
internal/app/coroutines/enqueueTasks.go	12.67%	62 Missing ⚠️
internal/app/subsystems/api/grpc/pb/notify.pb.go	44.44%	59 Missing and 1 partial ⚠️
test/dst/validator.go	0.00%	42 Missing ⚠️
cmd/notify/notify.go	0.00%	28 Missing ⚠️
test/dst/generator.go	0.00%	16 Missing ⚠️
...ernal/app/subsystems/api/grpc/pb/notify_grpc.pb.go	66.66%	10 Missing and 3 partials ⚠️
internal/app/subsystems/api/http/notify.go	67.74%	8 Missing and 2 partials ⚠️
internal/kernel/t_api/request.go	0.00%	4 Missing ⚠️
... and 4 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
- Coverage   56.29%   54.94%   -1.35%     
==========================================
  Files         122      129       +7     
  Lines       13364    13906     +542     
==========================================
+ Hits         7523     7641     +118     
- Misses       5389     5809     +420     
- Partials      452      456       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dfarr]

This looks great!

One thing that I'm not sure about atm is how many times we should (re)attempt an enqueue for a notify message? Our default logic is to retry until the timeout time (which is set to the same time as the promise timeout), does this make sense for notify? It's certainly the easiest to implement because we can just leave the logic as is.

[avillega]

Our other option is to just try to send it and do not care about any errors. I think the spirit of notify goes more in that direction.

…

On Jan 15, 2025, at 1:28 PM, David Farr ***@***.***> wrote: This looks great! One thing that I'm not sure about atm is how many times we should (re)attempt an enqueue for a notify message? Our default logic is to retry until the timeout time (which is set to the same time as the promise timeout), does this make sense for notify? It's certainly the easiest to implement because we can just leave the logic as is. — Reply to this email directly, view it on GitHub <#531 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACVCDLLDI24I3IDYHZ534PT2K3HJVAVCNFSM6AAAAABVH5YAVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTHE3TGNBQG4>. You are receiving this because you authored the thread.

[dfarr]

I'm up for that! On Wed, Jan 15, 2025 at 1:32 PM Andres Villegas ***@***.***> wrote:

…

Our other option is to just try to send it and do not care about any errors. I think the spirit of notify goes more in that direction. > On Jan 15, 2025, at 1:28 PM, David Farr ***@***.***> wrote: > > > This looks great! > > One thing that I'm not sure about atm is how many times we should (re)attempt an enqueue for a notify message? Our default logic is to retry until the timeout time (which is set to the same time as the promise timeout), does this make sense for notify? It's certainly the easiest to implement because we can just leave the logic as is. > > — > Reply to this email directly, view it on GitHub < #531 (comment)>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ACVCDLLDI24I3IDYHZ534PT2K3HJVAVCNFSM6AAAAABVH5YAVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTHE3TGNBQG4>. > You are receiving this because you authored the thread. > — Reply to this email directly, view it on GitHub <#531 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKS2OSUXQ7PGBPXD2UJX5L2K3HVHAVCNFSM6AAAAABVH5YAVKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJTHE3TQNRWG4> . You are receiving this because your review was requested.Message ID: ***@***.***>

[dfarr]

Damn man, even the cli is here!