Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type to the message sent by the sender subsystem #535

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

avillega
Copy link
Contributor

In order for the SDKs to correctly identify if the message it is getting
is a notify, invoke or resume.

@avillega avillega requested a review from dfarr January 22, 2025 19:44
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (de5339e) to head (84b7b23).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/subsystems/aio/sender/sender.go 0.00% 22 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
- Coverage   54.96%   54.83%   -0.14%     
==========================================
  Files         129      129              
  Lines       13906    13919      +13     
==========================================
- Hits         7644     7632      -12     
- Misses       5806     5830      +24     
- Partials      456      457       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avillega avillega merged commit fb84e20 into main Jan 22, 2025
4 of 6 checks passed
@avillega avillega deleted the avillega/notification-hot-fixes branch January 22, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants