Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more space for errors... #552

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

avillega
Copy link
Contributor

By making internal codes 1 digit larger, this should give us about an extra 90 error codes per http code.

By making internal codes 1 digit larger, this should give us about an
extra 90 error codes per http code.
@avillega avillega requested a review from dfarr February 24, 2025 23:47
@avillega
Copy link
Contributor Author

I know we talked about making the http error the last three digits, that will give us as bigger amount of errors to use, but it was ugly. I think 90 extra errors per http code should take us far.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.24%. Comparing base (ea61460) to head (99e9cf6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #552      +/-   ##
==========================================
+ Coverage   55.12%   55.24%   +0.11%     
==========================================
  Files         133      133              
  Lines       14163    14163              
==========================================
+ Hits         7808     7824      +16     
+ Misses       5892     5878      -14     
+ Partials      463      461       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dfarr
Copy link
Member

dfarr commented Feb 25, 2025

I know we talked about making the http error the last three digits, that will give us as bigger amount of errors to use, but it was ugly. I think 90 extra errors per http code should take us far.

I agree, every code having the same number of digits is nice!

@avillega avillega merged commit 7195f7f into main Feb 25, 2025
6 checks passed
@avillega avillega deleted the avillega/more-space-for-errors branch February 25, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants