DST horizontal partitioning #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for the html version.
avillega
commented
Mar 6, 2025
Comment on lines
+310
to
+319
| if isCreatePromiseAndTask { | ||
| promiseAndTaskResult := completion.Store.Results[0].CreatePromiseAndTask | ||
| util.Assert(promiseAndTaskResult.PromiseRowsAffected == 0 || promiseAndTaskResult.PromiseRowsAffected == 1, "Creating promise result must return 0 or 1 rows") | ||
| if promiseAndTaskResult.PromiseRowsAffected == 0 { | ||
| util.Assert(promiseAndTaskResult.TaskRowsAffected == 0, "If not promise was created a task must have not been created") | ||
| } | ||
| } else { | ||
| createPromiseResult := completion.Store.Results[0].CreatePromise | ||
| util.Assert(createPromiseResult.RowsAffected == 0 || createPromiseResult.RowsAffected == 1, "CreatePromise result must return 0 or 1 rows") | ||
| } |
There was a problem hiding this comment.
As a general note, I might want to come back to this code and refactor it in a cleaner way. the isCreatePromiseAndTask every where makes me believe there is a cleaner approach to it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
- Coverage 55.21% 52.38% -2.84%
==========================================
Files 133 133
Lines 14163 14408 +245
==========================================
- Hits 7820 7547 -273
- Misses 5881 6400 +519
+ Partials 462 461 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dfarr
approved these changes
Mar 8, 2025
Co-authored-by: David Farr <[email protected]>
Co-authored-by: David Farr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several related changes to be able to make the DST run faster and enable validations between promises and tasks.