fix(ci): remove the two disallowed metadata.json files and stop the check hiding on main - #9
Merged
Merged
Conversation
…check hiding on main README.md:173 and the PR template both say skill folders must not contain a metadata.json. Two do, and the folder-structure step in validate-skill.yml has been failing on them since 2f16a07. Because that workflow only ran on pull_request, main never checked itself, so the breakage was invisible on main and showed up as a red check on every unrelated PR instead. A check that is always red is worse than no check: it trains people past the one time it is right. Deleting them loses nothing. skills.json is what the marketplace reads, and it already carries both entries in full. The metadata.json copies had drifted: internal-link-builder said version 1.0.0 against 1.2.0 in skills.json, two releases stale, with a different description as well. A second source of truth that is already wrong is worth less than no second source of truth. Also runs the workflow on push to main, and widens the paths filter from a list of allowed filenames to skills/**. This job exists to reject files that should not be there, so filtering on the permitted names meant a PR adding only a disallowed file never triggered the job that exists to reject it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(ci): delete the two disallowed metadata.json files, and stop the check hiding on main
README.md:173 and the PR template both say skill folders must not contain a
metadata.json. Two do, and the folder-structure step in validate-skill.yml has
been failing on them since 2f16a07. Because that workflow only ran on
pull_request, main never checked itself, so the breakage was invisible on main
and showed up as a red check on every unrelated PR instead. A check that is
always red is worse than no check: it trains people past the one time it is
right.
Deleting them loses nothing. skills.json is what the marketplace reads, and it
already carries both entries in full. The metadata.json copies had drifted:
internal-link-builder said version 1.0.0 against 1.2.0 in skills.json, two
releases stale, with a different description as well. A second source of truth
that is already wrong is worth less than no second source of truth.
Also runs the workflow on push to main, and widens the paths filter from a list
of allowed filenames to skills/**. This job exists to reject files that should
not be there, so filtering on the permitted names meant a PR adding only a
disallowed file never triggered the job that exists to reject it.