Skip to content

Add Content-Length to make_ack request #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shenjinti merged 2 commits into from
Oct 13, 2025
Merged

Add Content-Length to make_ack request #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea78c82
Add Content-Length to make_ack request
slyoldfox Oct 12, 2025
79f56ac
cargo fmt
slyoldfox Oct 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/transaction/message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ use super::{endpoint::EndpointInner, make_call_id};
use crate::{rsip_ext::extract_uri_from_contact, transaction::make_via_branch, Result};
use rsip::{
header,
headers::Route,
headers::{ContentLength, Route},
prelude::{HeadersExt, ToTypedHeader, UntypedHeader},
Error, Header, Request, Response, StatusCode,
};
Expand Down Expand Up @@ -312,6 +312,7 @@ impl EndpointInner {
cseq.mut_method(rsip::Method::Ack).ok();
}
});
headers.push(Header::ContentLength(ContentLength::default())); // 0 because of vec![] below
headers.unique_push(Header::UserAgent(self.user_agent.clone().into()));
Ok(rsip::Request {
method: rsip::Method::Ack,
Expand Down
12 changes: 12 additions & 0 deletions src/transaction/tests/test_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,18 @@ Content-Length: 0\r\n\r\n";
let expected_uri = Uri::try_from("sip:[email protected]:5080;transport=tcp")?;
assert_eq!(ack.uri, expected_uri, "ACK must target the remote Contact");

// Check Content-Length
let content_length: String = ack
.headers
.iter()
.filter_map(|header| match header {
Header::ContentLength(content_length) => Some(content_length.value().to_string()),
_ => None,
})
.next()
.expect("ACK must include a Content-Length header");

assert_eq!(content_length, "0", "Content-Length of ACK must be 0");
let routes: Vec<String> = ack
.headers
.iter()
Expand Down