Skip to content

fix ack for domain name contact #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yeoleobun merged 1 commit into from
Dec 7, 2025
Merged

fix ack for domain name contact #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/transaction/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ impl Transaction {
}
}

pub async fn send_ack(&mut self, connection: Option<SipConnection>) -> Result<()> {
pub async fn send_ack(&mut self, mut connection: Option<SipConnection>) -> Result<()> {
if self.transaction_type != TransactionType::ClientInvite {
return Err(Error::TransactionError(
"send_ack is only valid for client invite transactions".to_string(),
Expand Down Expand Up @@ -466,11 +466,20 @@ impl Transaction {
} else {
ack.to_owned().into()
};
if let SipMessage::Request(ref req) = ack {
if let SipMessage::Request(req) = &ack {
if let Some(resp) = self.last_response.as_ref() {
if resp.status_code.kind() == StatusCodeKind::Successful {
// 2xx response, set destination from request
self.destination = destination_from_request(&req);
if let Some(dest) = destination_from_request(req) {
let (conn, addr) = self
.endpoint_inner
.transport_layer
.lookup(&dest, Some(&self.key))
.await?;

connection = Some(conn);
self.destination = Some(addr);
}
}
}
}
Expand Down