Skip to content

replace xinerama with xrandr #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

replace xinerama with xrandr #406

merged 1 commit into from
Mar 17, 2025

Conversation

@N-R-K
Copy link
Collaborator

@N-R-K N-R-K commented Mar 7, 2025

xrandr is supposedly the better replacement for xinerama. On my system, no packages (other than scrot) use xinerama while there's a bunch using xrandr, so it's likely a more common dependency which is probably already installed too.

Alternatively, instead of replacing it we could offer a build time config switch allowing the user to select between xrandr and xinerama.

@N-R-K
Copy link
Collaborator Author

N-R-K commented Mar 9, 2025

Anyone with multi monitor wants to try this out? The patch should be functional at it's current state. Though documentation and CI needs updating before merging - I'll do it later once the patch is confirmed to be good.

ping: @daltomi @zevweiss

@daltomi
Copy link
Collaborator

daltomi commented Mar 16, 2025

It works correctly. I tested it with only one external monitor (VGA output).

Various configurations, from different resolutions, and specifying the primary monitor via xrandr.

scrot -M0 (ok, primary iterating via xrandr)
scrot -M1 (ok)
scrot -M2 (ok, error as expected)

daltomi
daltomi reviewed Mar 16, 2025
View reviewed changes
@N-R-K N-R-K changed the base branch from master to v2 March 16, 2025 22:44
@N-R-K N-R-K changed the title wip: replace xinerama with xrandr replace xinerama with xrandr Mar 16, 2025
@N-R-K N-R-K marked this pull request as ready for review March 16, 2025 22:45
@N-R-K
replace Xinerama with Xrandr
cb18295 
Xrandr is supposedly the better replacement [0] for Xinerama.
on my system, no packages (other than scrot) use Xinerama while
there's a bunch using Xrandr, so it's likely a more common
dependency too which means it's more likely to be installed on
the user's system already.

[0]: https://wiki.archlinux.org/title/Multihead#Xinerama
@zevweiss
Copy link
Contributor

zevweiss commented Mar 17, 2025

FWIW I've also tested this and found no problems with it; looks good to me.

@N-R-K N-R-K merged commit fdd8860 into resurrecting-open-source-projects:v2 Mar 17, 2025
17 checks passed
@N-R-K N-R-K deleted the xrandr branch March 17, 2025 00:58
@N-R-K
Copy link
Collaborator Author

N-R-K commented Mar 17, 2025 •
edited
Loading

@daltomi @zevweiss thanks for testing! I've merged it into v2 branch where there's a couple other library requirement related changes happening too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daltomi daltomi daltomi left review comments

Assignees

No one assigned

Labels

ready for testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@N-R-K @daltomi @zevweiss