Skip to content

fix: copy buttons silently fail on insecure origins (clipboard fallback) #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mubashirrrr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: copy buttons silently fail on insecure origins (clipboard fallback) #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,12 +1346,37 @@ <h2 class="reveal" data-i18n="install.title">Get Started in Seconds</h2>
});

// ── Copy prompt from use case ──
// Clipboard with a fallback for insecure contexts (e.g. the page opened via
// file://), where navigator.clipboard is undefined and writeText() would throw,
// leaving the copy buttons silently dead.
function copyToClipboard(text) {
if (navigator.clipboard && window.isSecureContext) {
return navigator.clipboard.writeText(text);
}
return new Promise((resolve, reject) => {
try {
const ta = document.createElement('textarea');
ta.value = text;
ta.setAttribute('readonly', '');
ta.style.position = 'fixed';
ta.style.opacity = '0';
document.body.appendChild(ta);
ta.select();
const ok = document.execCommand('copy');
document.body.removeChild(ta);
ok ? resolve() : reject(new Error('copy command was rejected'));
} catch (err) {
reject(err);
}
});
}

function copyPrompt(el) {
const hint = el.querySelector('.uc-copy-hint');
const text = el.textContent.replace(hint.textContent, '').trim();
const copiedText = (i18n['common.copied'] && i18n['common.copied'][currentLang]) || 'Copied!';
const clickText = (i18n['common.click_to_copy'] && i18n['common.click_to_copy'][currentLang]) || 'Click to copy';
navigator.clipboard.writeText(text).then(() => {
copyToClipboard(text).then(() => {
el.classList.add('copied');
hint.textContent = copiedText;
setTimeout(() => { el.classList.remove('copied'); hint.textContent = clickText; }, 2000);
Expand All @@ -1372,7 +1397,7 @@ <h2 class="reveal" data-i18n="install.title">Get Started in Seconds</h2>
const cmd = block.querySelector('.cmd').textContent;
const copiedText = (i18n['common.copied'] && i18n['common.copied'][currentLang]) || 'Copied!';
const copyText = (i18n['common.copy'] && i18n['common.copy'][currentLang]) || 'Copy';
navigator.clipboard.writeText(cmd).then(() => {
copyToClipboard(cmd).then(() => {
const btn = block.querySelector('.copy-btn');
btn.textContent = copiedText;
btn.classList.add('copied');
Expand Down