Conversation
Replace mlx-rs/mlx-macros with quill-mlx/quill-mlx-macros across all workspace crates. The fork adds Metal memory management APIs that were missing from upstream, fixing unbounded GPU buffer cache growth (102GB+) in long-running MCP server sessions. - Cap Metal buffer cache at 2GB on MCP server startup - Update scaled_dot_product_attention call for new sinks parameter
Update all workspace crates to use quill-mlx 0.25.4 from crates.io instead of path dependencies. Update build.rs metallib discovery to also match quill-mlx-sys-* build directories.
Previous 0.25.4 was based on upstream main which had mlx-c v0.5.0 (MLX v0.30.6), causing kernel load failures at runtime. 0.25.5 is based on the v0.25.3 tag with mlx-c v0.2.0 (MLX v0.25.1). Revert scaled_dot_product_attention sinks parameter since the v0.25.x API doesn't have it.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mlx-rs/mlx-macroswithquill-mlx/quill-mlx-macros(our fork, published on crates.io)quill_mlx::metal::set_cache_limit(), fixing unbounded memory growth (102 GB+) in long-running sessionsscaled_dot_product_attentioncall for newsinksparameterquill-mlx-sys-*directoriesWhy fork
cargo install voiceis broken due to metallib path baked to temp build directory (oxiglade/mlx-rs#327)Fork details
quill-mlx, set as default)quill-mlx0.25.4,quill-mlx-sys0.2.1,quill-mlx-macros0.25.4Test plan
cargo check -p voicepassescargo build --release -p voicesucceedscargo test --workspace— all tests pass