Update RAID array name after scheduling its creation #6185
Merged
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
This is unblocked as our newest container builds are failing on missing newest pykickstart version: |
vojtechtrefny
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-test --testtype smoke |
|
The unit test failure is expected because our workflow will not build new container with a new pykickstart. |
|
/packit build |
|
Merging and doing directly a container rebuild. |
KKoukiou
approved these changes
Feb 26, 2025
|
Actually let's put the change in the spec file, and let unit tests build a new container here. |
Blivet can change the name for multiple reasons (invalid chars, name conflict etc.) so we need to make sure we have both the old and new name saved in case it is used in other kickstart commands like volgroup for example.
KKoukiou
force-pushed
the
main_raid-name-fix
branch
from
ade2c7a to
280a8cc
Compare
KKoukiou
temporarily deployed
to
gh-cockpituous
GitHub Actions
Inactive
|
/kickstart-tests --waive run already smoke tests |
|
Ignore Web UI tests, and RPM tests, known issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blivet can change the name for multiple reasons (invalid chars,
name conflict etc.) so we need to make sure we have both the old
and new name saved in case it is used in other kickstart commands
like volgroup for example.
We already do the same for the volgroup command in
_execute_volgroup_data. This is currently blocked by related pykickstart fix for RAID names, see pykickstart/pykickstart#534