Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restore function #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ipe-florian-hofer
Copy link

Problem:

  • the restore file is loaded into the new buffer
  • the eeprom_fields of the old buffer are decoded into ee
  • ee is patched in place via process_args
  • if erase_eeprom == 0 ee is applied to the new buffer
    => this results in new and old always being identical

Solution:

  • if file_path decode ee form new buffer
  • else decode ee from old buffer

Positive side effect:

  • while restoring from file the eeprom fields can still be patched
    on the fly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant