optimize index route#85
Open
naholyr wants to merge 2 commits into
Open
Conversation
Collaborator
|
I like this, thanks. I'd like more to make a lua script that runs inside redis. If I don't have the time in the following days we can still merge this. @cristiandouce what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current calls are made one after the other, not very efficient.
Amongst the 5 calls, 3 can be made in parallel, this is what
async.auto()will help to achieve transparently :)Note that the code would be simplier if the callbacks had a standard format
(err [, results…])but whatever.