prevent empty vfilter #115
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current code adds a trailing comma in case no extra video filters are defined. At least with my version of ffmpeg (5.1.6-0+deb12u1) this does not work and leads to: No such filter: '' Which is: ffmpeg interprets the (empty) part after the comma as filter and does not have such a filter. The patch only adds the comma if the extra filters are defined and are not empty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code adds a trailing comma in case no extra video filters are defined. At least with my version of ffmpeg (5.1.6-0+deb12u1) this does not work and leads to:
No such filter: ''
Which is: ffmpeg interprets the (empty) part after the comma as filter and does not have such a filter.
The patch only adds the comma if the extra filters are defined and are not empty.