feat: implement two-factor authentication (#399)#473
Open
abrak01 wants to merge 1 commit intorinafcode:mainfrom
Open
feat: implement two-factor authentication (#399)#473abrak01 wants to merge 1 commit intorinafcode:mainfrom
abrak01 wants to merge 1 commit intorinafcode:mainfrom
Conversation
- Add TOTP generation and verification via otplib (±1 window for clock drift) - Add QR code generation via qrcode for authenticator app setup - Add 8 one-time backup codes with bcrypt hashing and single-use consumption - Add MfaService with setup, confirm, verify, and disable flows - Add MFA DTOs (ConfirmMfaDto, VerifyMfaDto, DisableMfaDto) - Add mfaEnabled, mfaSecret, mfaBackupCodes fields to User entity - Add updateMfa() to UsersService - Add POST /auth/mfa/setup, /mfa/confirm, /mfa/verify, DELETE /auth/mfa/disable endpoints - Wire MfaService into AuthModule - Audit log MFA_ENABLED, MFA_DISABLED, MFA_FAILED events - Add 12 unit tests covering TOTP and backup code utilities Closes rinafcode#399
Contributor
|
Kindly resolve conflict |
Contributor
|
kindly resolve conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes #N
What does this PR do?
Type of change
Pre-merge checklist (required)
Branch & metadata
feature/issue-<N>-<slug>/fix/issue-<N>-<slug>conventiondevelopormain)Code quality & tests
npm run lint:ci— zero ESLint warningsnpm run format:check— Prettier reports no changes needednpm run typecheck— zero TypeScript errorsnpm run test:ci— all tests pass, coverage ≥ 70%.spec.tsunit testsError handling & NestJS best practices
class-validator/class-transformerdecorators and are wired through NestJS pipes (e.g. globalValidationPipeor explicit)any/unknownreaching the domain)BadRequestException,UnauthorizedException,ForbiddenException,NotFoundException) instead of genericErrorLoggeror central logger service) with meaningful, structured messagesAuthGuard, role/permissions guards, custom guards) are applied to all new/modified endpoints where appropriateAPI documentation / Swagger
/api(or Swagger UI) reflects new/changed endpoints correctlyBreaking changes
Breaking change description (if applicable)
Test evidence (required)
Commands run locally
Manual / API verification
Screenshots / recordings (if applicable)
Closes #399