Fix/escrow approval race condition#403
Merged
Xhristin3 merged 2 commits intorinafcode:mainfrom Apr 28, 2026
Merged
Conversation
- Add ESCROW_GUARD symbol to storage.rs - Add approve_with_guard: atomically checks has_approved, records approval, and increments count under ESCROW_GUARD reentrancy lock - Prevents duplicate approvals and concurrent read-modify-write on approval_count - Add 3 concurrency tests: duplicate rejection, multi-signer increment, guard-active rejection
|
@Chrisland58 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix escrow approval race condition
Addresses a critical data integrity issue where concurrent approvals could produce inconsistent
state:
check-record-increment sequence in reentrancy::with_guard, making approval atomic.
concurrent calls by the same signer are rejected with SignerAlreadyApproved.
guard, preventing double-counting of approval_count.
Files changed:
Tests added:
closes Fix race condition in concurrent approval scenarios #237