Fix/multisig validation edge cases#405
Merged
Xhristin3 merged 3 commits intorinafcode:mainfrom Apr 28, 2026
Merged
Conversation
- Implement duplicate signer detection in check_duplicate_signers (O(n²) address comparison) - Reject signers with zero weight in validate_create_escrow and validate_escrow_parameters - Fix validate_threshold to compare against total weight instead of signer count
…eshold boundaries - Add EscrowValidator::validate_multisig consolidating all edge case checks - Use checked_add to prevent u32 weight overflow - Enforce threshold within [1, total_weight] - Reject zero-weight and duplicate signers - Refactor validate_create_escrow and validate_escrow_parameters to delegate to validate_multisig - Add test_multisig_threshold_boundaries covering all edge cases
|
@Chrisland58 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Xhristin3
approved these changes
Apr 24, 2026
Contributor
|
@Chrisland58 resolve conflicts. |
1 similar comment
Contributor
|
@Chrisland58 resolve conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Multi-Signature Validation Edge Cases
Addresses edge case vulnerabilities in multi-signature validation.
Changes
replacing duplicated inline logic in validate_create_escrow and validate_escrow_parameters
Tests
Added test_multisig_threshold_boundaries covering:
closes Fix potential edge case in multi-signature validation #249