Skip to content

Feat/rust fix#463

Merged
Xhristin3 merged 4 commits intorinafcode:mainfrom
A5cend-dev:feat/rust-fix
Apr 28, 2026
Merged

Feat/rust fix#463
Xhristin3 merged 4 commits intorinafcode:mainfrom
A5cend-dev:feat/rust-fix

Conversation

@A5cend-dev
Copy link
Copy Markdown
Contributor

Summary

This PR resolves CI failures caused by Rust syntax errors and formatting issues in the teachlink contract repository, blocking cargo fmt --all -- --check and build validation.


Root Cause

CI was failing due to:

  • A stray invalid line inside a disabled test block in escrow_repository.rs
  • An extra unmatched } in concurrency_tests.rs
  • Missing import causing build failure (Vec)

These issues caused Rust parser errors and prevented formatting/build checks from completing.


Changes Made

escrow_repository.rs

  • Fixed syntax issue in a commented-out test block by properly commenting/removing stray line:

    • beneficiary: beneficiary.clone(),
  • Added missing import:

    • Vec from soroban_sdk

concurrency_tests.rs

  • Removed an extra trailing } causing unbalanced syntax in test module

Validation

Formatting Check

cargo fmt --all -- --check

✔ Passed

Build Check

cargo build --workspace

✔ Passed


Impact

  • Restores CI pipeline health
  • Ensures Rust formatting and parsing consistency
  • No functional logic changes were introduced

Notes

All fixes are minimal, syntax-only corrections with no behavior changes.


Closes CI failure for cargo fmt --all -- --check and build validation.

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Apr 27, 2026

Hey @A5cend-dev! 👋 It looks like this PR isn't linked to any issue.

If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g., Closes #123), or by clicking a button below:

Issue Title
#232 Fix race condition in concurrent approval scenarios Link to this issue

ℹ️ Learn more about linking PRs to issues

@Xhristin3 Xhristin3 merged commit b0f257f into rinafcode:main Apr 28, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants