Feat/rust fix#463
Merged
Xhristin3 merged 4 commits intorinafcode:mainfrom Apr 28, 2026
Merged
Conversation
|
Hey @A5cend-dev! 👋 It looks like this PR isn't linked to any issue. If this PR is for one of the issues assigned to you as part of a Wave, please link it to ensure your contribution is tracked properly. You can do this by adding a keyword to the PR description (e.g.,
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves CI failures caused by Rust syntax errors and formatting issues in the
teachlinkcontract repository, blockingcargo fmt --all -- --checkand build validation.Root Cause
CI was failing due to:
escrow_repository.rs}inconcurrency_tests.rsVec)These issues caused Rust parser errors and prevented formatting/build checks from completing.
Changes Made
escrow_repository.rsFixed syntax issue in a commented-out test block by properly commenting/removing stray line:
beneficiary: beneficiary.clone(),Added missing import:
Vecfromsoroban_sdkconcurrency_tests.rs}causing unbalanced syntax in test moduleValidation
Formatting Check
✔ Passed
Build Check
✔ Passed
Impact
Notes
All fixes are minimal, syntax-only corrections with no behavior changes.
Closes CI failure for
cargo fmt --all -- --checkand build validation.