refactor(constants): extract magic numbers and strings to named const…#294
Merged
RUKAYAT-CODER merged 2 commits intorinafcode:mainfrom Apr 29, 2026
Merged
Conversation
|
@shogun444 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Kindly resolve conflict |
1 similar comment
Contributor
|
Kindly resolve conflict |
Contributor
Author
|
@RUKAYAT-CODER I resolved the conflicts please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors selected parts of the codebase to replace magic numbers and hardcoded strings with named constants, improving readability and maintainability.
A centralized constants file was introduced and used across core modules to eliminate repeated values.
Closes #205
Type of change
Changes
Added
src/constants/app.constants.tsfor shared constantsReplaced magic values in:
api.tsapiInterceptors.tsToastContext.tsxperformanceUtils.tsmessagingStore.tsMinor fixes to ensure build stability after refactoring:
envValidation.tsErrorBoundarySystem.tsxTesting
Verified application runs locally with
npm run devConfirmed no runtime or console errors after refactor
Ensured existing functionality remains unchanged
npm run type-checknpm run lintnpm run testnpm run buildNotes