Refactor: Clean up unused props and dead code branches#341
Merged
RUKAYAT-CODER merged 4 commits intorinafcode:mainfrom Apr 29, 2026
Merged
Refactor: Clean up unused props and dead code branches#341RUKAYAT-CODER merged 4 commits intorinafcode:mainfrom
RUKAYAT-CODER merged 4 commits intorinafcode:mainfrom
Conversation
|
@Nacho1499 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Contributor
|
Kindly resolve conflict |
Nacho1499
force-pushed
the
fix/Unused-Component-Code
branch
from
cc5611d to
5e06780
Compare
Contributor
Author
|
Conflict can't be resolved. Because the conflict button is grayed out. |
Contributor
Author
|
I have tried resolving it manually from my editor . But same result. But I will still try to resolving it. Thanks |
Contributor
|
ok thanks |
Nacho1499
force-pushed
the
fix/Unused-Component-Code
branch
from
ee3e873 to
045fbed
Compare
Contributor
Author
|
conflict resolved |
Contributor
|
Not yet resolved. |
Contributor
Author
|
conflict resolved . thanks |
Contributor
|
Thank you |
Contributor
Author
|
nice working on ur repo. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #209
PR Description:
This PR addresses the cleanup of dead code branches and unused props within the Web3 component directory. It also modernizes the ESLint configuration to ensure long-term code quality.
Changes Made:
-Code Cleanup: Removed unreachable validation logic and unused props in .TransactionManager.tsx
-Hook Optimization: Refactored to resolve warnings and improved state synchronization.useWeb3Wallet.tsexhaustive-deps
-Config Migration: Moved ignore patterns from to to comply with ESLint 9+ standards..eslintignoreeslint.config.mjs
-Dependency Management: Integrated to resolve formatting conflicts.eslint-config-prettier
Acceptance Criteria Verified:
[x] No dead code branches remain.
[x] All component props are utilized.
[x] passes with zero warnings/errors.npm run lint
fix:
-Bug Fixes