Prep methods for additional io_uring features #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Probably I can't review this until after the new year, but superficially its exciting. Thanks :) |
Collaborator
|
Ahh I see now that this was supposed to supercede #26. Reviewing fully now |
Collaborator
withoutboats
left a comment
withoutboats
left a comment
There was a problem hiding this comment.
Overall this all looks great! Thanks so much, I'll be excited to add it. Only changes I propose are small stylistic ones.
Sorry again for letting it sit a month!
| } | ||
| } | ||
|
|
||
| pub unsafe fn as_socket_addr(&self) -> io::Result<SockAddr> { |
Collaborator
There was a problem hiding this comment.
I want to make sure I have a correct understanding of this API: this function is safe to call after as the prep_accept SQE you passed this to has completed, and calling it before it has completed would be incorrect. Is that right?
| let mut ring = iou::IoUring::new(2)?; | ||
| let (read, _write) = net::UnixStream::pair()?; | ||
| let uname = nix::sys::utsname::uname(); | ||
| let version = semver::Version::parse(uname.release()); |
Collaborator
There was a problem hiding this comment.
added 2 commits
January 22, 2020 21:54
# Conflicts: # Cargo.toml # src/lib.rs # src/sqe.rs # tests/poll.rs
Collaborator
|
Merged into master! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@withoutboats need your opinion about my tryout with nix types