Several bug fixes and improvements #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Liu Jiang <[email protected]>
Replace io_uring_wait_cqes() with the simpler io_uring_wait_cqe_nr(). Signed-off-by: Liu Jiang <[email protected]>
When creating a new IoUring instance, some feature flags needs additional configuraiton data, such as SQ_AFF needing a cpu id and ATTACH_WQ needing a reference io_uring fd. An advanced Builder is needed to support these flags. Signed-off-by: Liu Jiang <[email protected]>
Safe Wrapping<u32> should be used instead of u32. Also validate the input parameter `count` for safety. Signed-off-by: Liu Jiang <[email protected]>
Both HardLinked and SoftLinked provides terminate() method to mark the end of IO chain, so there may be left over descriptors on the CQEs. Ensure all possible left over descriptors are consumed when dropping. Signed-off-by: Liu Jiang <[email protected]>
Ensure all descriptors returned by SQEs are zeroed for safety. Signed-off-by: Liu Jiang <[email protected]>
Now all allocated event descriptor are zeroed, there's no need to call pre_nop() for every descriptor any more. Signed-off-by: Liu Jiang <[email protected]>
Signed-off-by: Liu Jiang <[email protected]>
Signed-off-by: Liu Jiang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the iou code, I found there are possible bugs and worked out fixes for them.
But I have no io_uring capable systems to trigger and reproduce the bug:(