Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix package-lock.json #1152

Closed
wants to merge 8 commits into from
Closed

chore: fix package-lock.json #1152

wants to merge 8 commits into from

Conversation

mvadari
Copy link
Collaborator

@mvadari mvadari commented Apr 7, 2025

High Level Overview of Change

This PR fixes the package-lock.json file and changes CI to use npm ci instead of npm install to make it easier to catch such issues in the future (it's also more efficient).

Context of Change

The package-lock.json appears to have gotten messed up between #1140 and #1149

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Translation Updates
  • Release

TypeScript/Hooks Update

  • Updated files to React Hooks
  • Updated files to TypeScript

Before / After

Test Plan

CI passes with the new command.

@mvadari
Copy link
Collaborator Author

mvadari commented Apr 7, 2025

Might need #984 instead of upgrading redux-thunk (that PR removes the package)

@pdp2121 pdp2121 mentioned this pull request Apr 8, 2025
8 tasks
@mvadari
Copy link
Collaborator Author

mvadari commented Apr 8, 2025

Closed in favor of #984

@mvadari mvadari closed this Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants