ggml-cpu: extend RVV quantization vec dot to higher VLENs#10
Open
taimur-10x wants to merge 61 commits intomasterfrom
Open
ggml-cpu: extend RVV quantization vec dot to higher VLENs#10taimur-10x wants to merge 61 commits intomasterfrom
taimur-10x wants to merge 61 commits intomasterfrom
Conversation
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-vlens
branch
from
86ffc7e to
bd69a20
Compare
rehan-10xengineer
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
2 times, most recently
from
f83ddf7 to
c7c6abc
Compare
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
3 times, most recently
from
cf95828 to
05a5425
Compare
rehan-10xengineer
force-pushed
the
10x/riscv-quant-vec-dot-128b
branch
from
05a5425 to
80c0ac3
Compare
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-vlens
branch
from
bd69a20 to
aa171a2
Compare
github-actions
Bot
added
documentation
* Fix flashattention support check for devices that don't support subgroups * set path to none if kv_tile doesn't fit
…2317) * ggml-cpu: cmake: append xsmtvdotii march for SpacemiT IME When GGML_CPU_RISCV64_SPACEMIT=ON is set, ime1_kernels.cpp contains inline asm for the vmadot family which requires the xsmtvdotii custom extension.(problem can see in some blogs and make sure in K3 platform) The current CMakeLists does not include xsmtvdotii, so any toolchain that honours the explicit -march (tested with SpacemiT GCC 15.2) fails at the assembler stage: Error: unrecognized opcode `vmadot v16,v14,v0', extension `xsmtvdotii' required Append _xsmtvdotii to MARCH_STR when GGML_CPU_RISCV64_SPACEMIT is enabled so the IME path can actually build with a capable toolchain. No effect on builds that leave GGML_CPU_RISCV64_SPACEMIT off. toolchain from https://www.spacemit.com/community/resources-download/Tools * Update ggml/src/ggml-cpu/CMakeLists.txt Co-authored-by: alex-spacemit <jinghui.huang@spacemit.com> --------- Co-authored-by: alex-spacemit <jinghui.huang@spacemit.com>
* ggml-cuda: refactor fusion code * apply formatting + make env variable truthy
…gml-org#22293) * ggml-cpu : disable tiled matmul on AIX to fix page boundary segfault vec_xst operations in the tiled path crash on AIX when writing near 4KB page boundaries due to strict memory protection. Fall back to mnpack implementation on AIX for stable execution. Signed-off-by: Shalini Salomi Bodapati <Shalini.Salomi.Bodapati@ibm.com> * Update ggml/src/ggml-cpu/llamafile/sgemm.cpp Co-authored-by: Aaron Teo <taronaeo@gmail.com> * Update sgemm.cpp * Update sgemm.cpp --------- Signed-off-by: Shalini Salomi Bodapati <Shalini.Salomi.Bodapati@ibm.com> Co-authored-by: Aaron Teo <taronaeo@gmail.com>
* webui: instant mic stop, race-free recorder restart * webui: faster WAV PCM encode via hoisted channels and Int16Array * chore: update webui build output * webui: drop setTimeout(0) hack and harden cancelRecording * chore: update webui build output
Co-authored-by: Rehan Qasim <rehan.qasim@10xengineers.ai>
taimur-10x
force-pushed
the
10x/riscv-quant-vec-dot-vlens
branch
from
aa171a2 to
5cce4e3
Compare
github-actions
Bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds RVV implementations for quantized vector dot kernels (for VLENs 512-bit and 1024-bit).
Key Changes
ggml_vec_dot_tq1_0_q8_K_vl512.Testing
Kernels were functionally tested through
test-quantize-fnsfor VLENs512-bitand1024-bitwith QEMU, usingtest-quantize-fns.