Skip to content

Conversation

@silver-ymz
Copy link
Member

@silver-ymz silver-ymz commented Jan 7, 2026

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix failed CI https://buildkite.com/risingwavelabs/pull-request/builds/88963#019b9326-f62f-451a-ac2d-711b9aa350f2

It seems that it's a regression introduced in #24289. I'm not sure about it.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

Copilot AI review requested due to automatic review settings January 7, 2026 03:54
@github-actions github-actions bot added the type/fix Type: Bug fix. Only for pull requests. label Jan 7, 2026
@silver-ymz silver-ymz added ci/run-e2e-tests and removed type/fix Type: Bug fix. Only for pull requests. labels Jan 7, 2026
@silver-ymz silver-ymz added the type/fix Type: Bug fix. Only for pull requests. label Jan 7, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a regression introduced in #24289 where the Merge executor's BufferChunks implementation would panic when all upstream inputs closed unexpectedly. The fix replaces an unreachable!() assertion with proper error handling to enable graceful recovery.

Key Changes:

  • Replaced unreachable!() panic with StreamExecutorError::channel_closed() when upstream inputs are closed
  • Added explanatory comment describing when this scenario can occur (e.g., during exchange channel closure during recovery)

@silver-ymz silver-ymz force-pushed the fix/merge-empty-upstream branch from ed50769 to 9f6630c Compare January 7, 2026 03:59
@BugenZhao
Copy link
Member

Is this the same issue as #24336?

Perhaps we should identify the root cause and fix it instead.
Some more discussions here: https://risingwave-labs.slack.com/archives/C094S2N254M/p1767691876158269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/run-e2e-tests type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants