fix: normalize date parsing for Safari browser compatibility#1744
Conversation
- Add normalizeDateString helper that converts space-separated datetimes to ISO-8601 with T separator (Safari fix) - Auto-append 'Z' suffix for timezone-naive strings - Add try/catch for robust error handling - Add unit tests for various date formats Fixes ritesh-1918#1411
|
@duongynhi000005-oss is attempting to deploy a commit to the ritesh Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hi @duongynhi000005-oss! 🙌 Thank you so much for your excellent contribution: "fix: normalize date parsing for Safari browser compatibility"! We really appreciate the high-quality code and effort you have put into the platform. Just a quick, friendly heads-up as we prepare our manual merging and verification queues—please make sure to complete all the mandatory community steps listed below. Once those manual steps are verified, we'll get your PR officially merged into the Let's build something amazing together! 🚀🔥 🌟 Project Support & Developer Network (Show Some Love!)As we prepare our manual verification and merging queues, please take a quick moment to ensure you have completed all four community steps:
Note: Having all four steps completed manually is required before your PR points are officially cleared. |
|
Hi @duongynhi000005-oss! 🙌 Thank you so much for your excellent contribution: "fix: normalize date parsing for Safari browser compatibility"! We really appreciate the high-quality code and effort you have put into the platform. Just a quick, friendly heads-up as we prepare our manual merging and verification queues—please make sure to complete all the mandatory community steps listed below. Once those manual steps are verified, we'll get your PR officially merged into the Let's build something amazing together! 🚀🔥 🌟 Project Support & Developer Network (Show Some Love!)As we prepare our manual verification and merging queues, please take a quick moment to ensure you have completed all four community steps:
Note: Having all four steps completed manually is required before your PR points are officially cleared. |
|
Merged locally into gssoc branch. Thank you for your GSSoC contribution! 🚀🔥 |
Fixes #1411
Changes
Safari Issue
Safari's constructor rejects format (space between date and time) but accepts . This fix normalizes the format before parsing.