Add Docker healthchecks to docker-compose services#186
Open
RemmyAcee wants to merge 2 commits intoritik4ever:mainfrom
Open
Add Docker healthchecks to docker-compose services#186RemmyAcee wants to merge 2 commits intoritik4ever:mainfrom
RemmyAcee wants to merge 2 commits intoritik4ever:mainfrom
Conversation
|
@OluRemiFour is attempting to deploy a commit to the ritik4ever's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Done, Close: #186 |
|
@RemmyAcee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close: #171
I have added the requested Docker healthchecks to your docker-compose.yml file.
Here is what was changed:
Backend Healthcheck: Added a curl test for http://localhost:3001/api/health with a 10s interval and 3 retries.
Frontend Healthcheck: Added a TCP port check (nc -z localhost 3000) with a 10s interval and 3 retries.
Dependencies: Updated the frontend's depends_on setting to use the condition: service_healthy check for the backend, ensuring it waits for the backend API to be ready before starting.