security: add X-StellarStream-Signature HMAC-SHA256 header to webhooks#187
Open
Dafuriousis wants to merge 1 commit intoritik4ever:mainfrom
Open
security: add X-StellarStream-Signature HMAC-SHA256 header to webhooks#187Dafuriousis wants to merge 1 commit intoritik4ever:mainfrom
Dafuriousis wants to merge 1 commit intoritik4ever:mainfrom
Conversation
Wave 4 – Security hardening
## What changed
- webhook.ts: export computeSignature(secret, body) helper that computes
sha256=<hex> via HMAC-SHA256 (crypto.createHmac)
- webhookWorker.ts: replace inline createHmac call with computeSignature;
rename header X-Webhook-Signature → X-StellarStream-Signature
- webhook.test.ts: add two unit tests for computeSignature
• cross-validates against a manual createHmac call
• asserts a known fixed digest (hello / secret)
- README.md: update webhook signing section – correct header name,
add full Node.js verification example using timingSafeEqual
## Why
Webhook consumers had no way to verify that a delivery originated from
StellarStream. The HMAC-SHA256 signature lets receivers authenticate
payloads before processing them, preventing spoofed or replayed events.
## Verification
All 6 webhook tests pass (npm test -- run src/services/webhook.test.ts).
|
@Dafuriousis is attempting to deploy a commit to the ritik4ever's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Dafuriousis Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #157
Wave 4 – Security hardening
What changed
Why
Webhook consumers had no way to verify that a delivery originated from StellarStream. The HMAC-SHA256 signature lets receivers authenticate payloads before processing them, preventing spoofed or replayed events.
Verification
All 6 webhook tests pass (npm test -- run src/services/webhook.test.ts).