Skip to content

[Graphite MQ] Draft PR GROUP:spec_f0bfa4 (PRs 4248)#4250

Closed
graphite-app[bot] wants to merge 1 commit intomainfrom
gtmq_spec_f0bfa4_1771626640255-85949c1c-e464-4df3-bf65-4d4f16d3bf27
Closed

[Graphite MQ] Draft PR GROUP:spec_f0bfa4 (PRs 4248)#4250
graphite-app[bot] wants to merge 1 commit intomainfrom
gtmq_spec_f0bfa4_1771626640255-85949c1c-e464-4df3-bf65-4d4f16d3bf27

Conversation

@graphite-app
Copy link
Contributor

@graphite-app graphite-app bot commented Feb 20, 2026

This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.

The following PRs are included in this draft PR:

# Description

This change removes several tabs from the actor details interface, including Queue, Traces, Workflow, and Database tabs. The corresponding tab triggers and content sections have been removed from the UI. Additionally, the import for `ActorWorkflowTab` has been moved to maintain proper import organization.

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] This change requires a documentation update

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

## Checklist:

- [ ] My code follows the style guidelines of this project
- [ ] I have performed a self-review of my code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
@railway-app
Copy link

railway-app bot commented Feb 20, 2026

This PR was not deployed automatically as @graphite-app[bot] does not have access to the Railway project.

In order to get automatic PR deploys, please add @graphite-app[bot] to your workspace on Railway.

@claude
Copy link

claude bot commented Feb 20, 2026

PR Review: fix(dashboard): hide unsupported tabs (#4248)

Note: This PR has already been merged to main via the Graphite merge queue (commit 6f381dc7). This review notes issues for follow-up.

What the PR Does

Removes four tab sections (Queue, Traces, Workflow, Database) from the actor details UI in frontend/src/components/actors/actors-actor-details.tsx, and cleans up the previously commented-out Logs and Metrics tab blocks.

Issues

Unused Imports Left Behind

The PR removes the tab content for Queue, Traces, Workflow, and Database, but does not remove their corresponding imports. These are now dead code in main:

import { ActorDatabaseTab } from "./actor-db-tab";    // unused after Database tab removal
import { ActorQueueTab } from "./actor-queue-tab";     // unused after Queue tab removal
import { ActorTracesTab } from "./actor-traces-tab";   // unused after Traces tab removal
import { ActorWorkflowTab } from "./workflow/actor-workflow-tab"; // unused after Workflow tab removal

The PR moved ActorWorkflowTab's import to a different position (described as "maintaining proper import organization") but the usage was removed — the import should have been deleted entirely. The other three were not touched at all. These unused imports likely contributed to the Railway build failures (frontend-inspector, website, ladle) visible in the CI output.

Recommended follow-up: Remove all four unused imports.

Orphaned TabsContent for Logs

After the merge, main contains a TabsContent value="logs" with no corresponding TabsTrigger value="logs". This content is unreachable from the UI unless navigated to directly via URL/state. This appears to be a pre-existing issue, but worth tracking.

What Was Done Well

  • Removing the commented-out Logs and Metrics tab blocks is good cleanup — dead commented-out code was correctly deleted rather than left to accumulate.
  • The scope of the change is narrow and focused.

PR Description Nit

The PR marks this as a "Breaking change" but removing unfinished/unsupported tabs is more accurately a bug fix or UI cleanup. The PR title correctly uses fix(... prefix.

Follow-up Recommended

// Remove these four imports from actors-actor-details.tsx:
import { ActorDatabaseTab } from "./actor-db-tab";
import { ActorQueueTab } from "./actor-queue-tab";
import { ActorTracesTab } from "./actor-traces-tab";
import { ActorWorkflowTab } from "./workflow/actor-workflow-tab";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant