[Graphite MQ] Draft PR GROUP:spec_832234 (PRs 4259, 4249)

[graphite-app]

This draft PR was created by the Graphite merge queue.
Trunk will be fast forwarded to the HEAD of this PR when CI passes, and the original PRs will be closed.

The following PRs are included in this draft PR:

• #4259
• #4249

[railway-app]

This PR was not deployed automatically as @graphite-app[bot] does not have access to the Railway project.

In order to get automatic PR deploys, please add @graphite-app[bot] to your workspace on Railway.

[claude]

PR Review

This is a merge queue PR combining two changes: #4249 (dashboard: bring new tabs back) and #4259 (fix SQLite teardown logic).

---

PR #4259 — fix(rivetkit): fix sqlite teardown logic

The core fix is solid: onDisconnect is now properly await-ed before the actor is allowed to sleep, preventing a race condition where the SQLite DB could be closed while an async onDisconnect callback was still writing to it.

What's fixed correctly:

• connDisconnected changed from fire-and-forget to async/await, properly blocking the sleep path
• resetSleepTimer() moved into the finally block so it only triggers after the callback completes
• #pendingDisconnectCount counter + ActiveDisconnectCallbacks enum variant block sleep while disconnect callbacks are in-flight
• try/finally in conn/mod.ts ensures CONN_DRIVER_SYMBOL is always cleared even if connDisconnected throws
• closed flag + mutex-guarded close() in both db/mod.ts and db/drizzle/mod.ts prevents double-close and guards execute() calls after teardown
• busy_timeout = 5000 and journal_mode = WAL pragmas are appropriate defaults for file-backed databases

Issues:

1. SQL string interpolation in test fixtures (minor)

In actor-db-drizzle.ts and actor-db-raw.ts, Date.now() is interpolated directly into a SQL string. It returns a number so there is no injection risk here, but interpolating values directly into SQL strings is a pattern worth avoiding in fixtures that others may copy. Consider using the parameterized form instead (consistent with other queries in these fixtures that already use c.db.execute(query, ...args)).

2. Test timing relies on implicit sleep behavior (minor)

test("completes onDisconnect DB writes before sleeping", async (c) => {
    await actor.configureDisconnectInsert(true, 250);
    await waitFor(driverTestConfig, SLEEP_WAIT_MS + 250);
    await actor.configureDisconnectInsert(false, 0);
    expect(await actor.getDisconnectInsertCount()).toBe(1);
});

The test implicitly relies on the actor having triggered at least one connection disconnect during the SLEEP_WAIT_MS window. A comment explaining why the count is expected to be exactly 1 (i.e., one client connection closes when the actor sleeps) would help future readers.

---

PR #4249 — feat(dashboard): bring new tabs back

Bug: database tab has content but no trigger

The diff adds <TabsContent value="database"> but does not add a corresponding <TabsTrigger value="database">. Looking at the current file, the tab bar renders: State, Connections, Queue, Workflow, Metadata — there is no "Database" entry. The ActorDatabaseTab component will never be reachable through the UI.

Either the trigger needs to be added alongside Queue and Workflow, or the TabsContent for database should be deferred until the trigger is also ready.

Minor: inconsistent className on the new TabsContent blocks

• queue: "min-h-0 flex-1 mt-0"
• workflow: "min-h-0 flex-1 mt-0 h-full"
• database: "min-h-0 min-w-0 flex-1 mt-0 h-full"

The database content has an extra min-w-0 that queue and workflow don't. If intentional (e.g., the database component needs horizontal overflow handling), a comment would clarify why. If not, it should be made consistent.

---

Summary

	Severity	Location
Missing database TabsTrigger	Bug	actors-actor-details.tsx
SQL interpolation in test fixtures	Minor	actor-db-drizzle.ts, actor-db-raw.ts
Test comment clarity	Nit	actor-db.ts
Inconsistent min-w-0 on database TabsContent	Nit	actors-actor-details.tsx

The SQLite teardown fix (#4259) is correct and well-tested. The primary concern is the missing tab trigger for the database tab in #4249.