Skip to content

Comments

chore: sqlite launch#4307

Open
NathanFlurry wants to merge 2 commits intomainfrom
02-24-chore_sqlite_launch
Open

chore: sqlite launch#4307
NathanFlurry wants to merge 2 commits intomainfrom
02-24-chore_sqlite_launch

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@railway-app
Copy link

railway-app bot commented Feb 25, 2026

🚅 Deployed to the rivet-pr-4307 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 25, 2026 at 6:59 am
mcp-hub ✅ Success (View Logs) Web Feb 25, 2026 at 6:50 am
frontend-inspector 😴 Sleeping (View Logs) Web Feb 25, 2026 at 3:13 am
frontend-cloud ❌ Build Failed (View Logs) Web Feb 25, 2026 at 3:04 am
ladle ❌ Build Failed (View Logs) Web Feb 25, 2026 at 3:01 am

@claude
Copy link

claude bot commented Feb 25, 2026

PR Review: chore: sqlite launch

This PR adds a blog/changelog post announcing SQLite for Rivet Actors. The content is well-written and the code examples are technically accurate. One critical issue needs to be resolved before merging.


Critical Issue

Incomplete "Built-in Database Explorer" section (line 357–358)

The section contains only a TODO placeholder:

## Built-in Database Explorer

TODO

This will be published verbatim if merged. Either fill in the content or remove the section heading entirely before shipping.


Minor Issues

Duplicate imports from the same module in the Drizzle example

The Drizzle tab has two separate import lines from rivetkit/db/drizzle:

import { db } from "rivetkit/db/drizzle";
import { integer, sqliteTable, text } from "rivetkit/db/drizzle";

These should be merged into a single import:

import { db, integer, sqliteTable, text } from "rivetkit/db/drizzle";

Drizzle import inconsistency

The Drizzle example imports schema types from rivetkit/db/drizzle but operators from drizzle-orm directly:

import { eq } from "drizzle-orm";

This is technically correct (operators live in drizzle-orm, not drizzle-orm/sqlite-core), but a brief inline comment explaining why operators come from the drizzle-orm package and not rivetkit/db/drizzle would help readers.

React useEffect missing cancellation guard

In the Realtime React example:

useEffect(() => {
  if (!connection) return;
  connection.getTodos().then(setTodos);
}, [connection]);

This lacks cleanup to guard against state updates on unmounted components or stale closures when connection changes. As example code, it gets copied verbatim. A small guard would demonstrate better practice:

useEffect(() => {
  if (!connection) return;
  let cancelled = false;
  connection.getTodos().then((todos) => { if (!cancelled) setTodos(todos); });
  return () => { cancelled = true; };
}, [connection]);

Confirmations

  • Frontmatter fields (author, published, category, title, description) are all present and valid per CLAUDE.md conventions.
  • All import paths (rivetkit, rivetkit/db, rivetkit/db/drizzle) are backed by real package exports.
  • queue, event, actor, setup are all correctly imported from rivetkit.
  • Linked doc pages (/docs/actors/sqlite, /docs/actors/sqlite-drizzle) exist in the repo.
  • Domain usage is correct (rivet.dev, github.com/rivet-dev/rivet).

The TODO placeholder is the only blocker. Everything else is polish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants