Skip to content

fix(frontend): fix inspector public path#4323

Open
NathanFlurry wants to merge 1 commit into02-26-fix_rivetkit0_fix_wf_history_diverged_bugfrom
02-20-fix_frontend_fix_inspector_public_path
Open

fix(frontend): fix inspector public path#4323
NathanFlurry wants to merge 1 commit into02-26-fix_rivetkit0_fix_wf_history_diverged_bugfrom
02-20-fix_frontend_fix_inspector_public_path

Conversation

@NathanFlurry
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@NathanFlurry
Copy link
Member Author

NathanFlurry commented Feb 27, 2026

@railway-app
Copy link

railway-app bot commented Feb 27, 2026

🚅 Deployed to the rivet-pr-4323 environment in rivet-frontend

Service Status Web Updated (UTC)
website 😴 Sleeping (View Logs) Web Feb 27, 2026 at 1:09 am
frontend-cloud 😴 Sleeping (View Logs) Web Feb 27, 2026 at 1:08 am
frontend-inspector 😴 Sleeping (View Logs) Web Feb 27, 2026 at 1:07 am
mcp-hub ✅ Success (View Logs) Web Feb 27, 2026 at 12:57 am
ladle ❌ Build Failed (View Logs) Web Feb 27, 2026 at 12:57 am

@NathanFlurry NathanFlurry force-pushed the 02-26-fix_rivetkit0_fix_wf_history_diverged_bug branch from 84d288e to c34c1d0 Compare February 27, 2026 00:56
@claude
Copy link

claude bot commented Feb 27, 2026

PR Review: fix(frontend): fix inspector public path

Overall Assessment: Simple, targeted one-line fix. No significant concerns.


Summary

This PR adds a single line to frontend/apps/inspector/vite.config.ts:

publicDir: path.resolve(__dirname, ../../public),

This points the inspector's Vite publicDir to frontend/public/, which contains shared static assets (favicon.svg, logo.svg, examples/).


Analysis

Correctness: The fix looks correct. Without an explicit publicDir, Vite defaults to a public/ directory relative to the root. Since root is set to __dirname (i.e., frontend/apps/inspector/) and that directory has no public/ folder of its own, the inspector was not serving any static assets. Pointing it to frontend/public/ aligns it with the shared assets used by other frontend builds.

Consistency: Other app configs (engine, cloud) use mergeConfig(baseViteConfig(), ...) from vite.base.config.ts. The inspector app is self-contained and doesn't follow that pattern, so explicitly setting publicDir here is the right approach for this config style.

Path calculation: path.resolve(__dirname, "../../public") correctly resolves from frontend/apps/inspector/frontend/public/. The pattern is consistent with how envDir is already set in the same file.

Docker build: The inspector.Dockerfile already copies frontend/public/examples/ into the build context, confirming these assets are expected to be available during the inspector build.


Minor Observations

  • No other vite configs use publicDir explicitly — this is the only one that needed it due to its non-standard root placement inside apps/inspector/. This is not a problem but worth noting for future app additions under apps/.
  • The PR description template wasn't filled out (type of change, testing, checklist). For a one-liner fix this is minor, but worth noting for process consistency.

No blocking issues. The change is minimal, correct, and well-scoped. ✓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant