chore(core): simplify config

[NathanFlurry]

No description provided.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivetkit-serverless	Ready	Preview	Comment	Oct 5, 2025 7:19am

[claude]

Claude finished @NathanFlurry's task —— View job

---

PR Review: Config Simplification

I've completed a comprehensive review of this config simplification PR. Here's my detailed feedback:

Review Tasks:

• Analyze core config changes in src/client/config.ts
• Review driver config changes in src/drivers/engine/config.ts
• Examine registry run config changes in src/registry/run-config.ts
• Check for breaking changes across modified files
• Assess security and performance implications
• Evaluate test coverage impact
• Provide comprehensive feedback

---

✅ Overall Assessment: Good Refactoring

This PR successfully consolidates and simplifies the configuration system by creating better inheritance hierarchies and reducing duplication. The changes follow good software engineering practices and maintain backward compatibility.

🎯 Key Improvements

1. Better Config Inheritance: Engine config now properly extends ClientConfig, eliminating duplication of common properties like endpoint, namespace, and runnerName.

2. Simplified Type Names: Renamed schemas to be more consistent:

   • ConfigSchema → EngingConfigSchema (note: typo in name)
   • RunConfigSchema → RunnerConfigSchema
   • RunConfig → RunnerConfig

3. Centralized Type Definitions: Moved GetUpgradeWebSocket type to utils.ts for better reusability.

4. Streamlined Client Config: Removed the unnecessary api object with host/port defaults and made endpoint non-nullable with a sensible default.

⚠️ Issues Found

Critical Issue - Typo in Schema Name

// packages/rivetkit/src/drivers/engine/config.ts:5
export const EngingConfigSchema = z  // Should be "EngineConfigSchema"

This typo appears consistently across multiple files. While it works functionally, it's confusing and should be fixed.

Breaking Changes

The following changes could break existing code:

1. Client Config Structure (src/client/config.ts:6-42):

   • Removed api.host and api.port fields
   • Changed endpoint from nullable to optional with default
   • Reordered fields in the schema

2. Type Renames:

   • RunConfig → RunnerConfig
   • InputConfig → EngineConfigInput
   • Config → EngineConfig

🔒 Security Assessment

No security concerns identified. The changes:

• Maintain proper environment variable handling
• Don't expose sensitive information
• Keep token handling secure with proper transformation

⚡ Performance Implications

Minor positive impact:

• Reduced schema parsing overhead by eliminating duplicate field definitions
• More efficient config merging using zod's .merge() instead of manual extension

🧪 Test Coverage Impact

Potential test failures: Tests using the old config structure or type names will need updates. Specifically:

• Tests importing RunConfig type need to use RunnerConfig
• Tests expecting the old api.host/api.port structure will fail
• Engine driver tests using old type names need updates

📝 Recommendations

1. Fix the typo: Rename EngingConfigSchema to EngineConfigSchema throughout the codebase
2. Add migration guide: Document the breaking changes for users upgrading
3. Update tests: Ensure all tests pass with the new config structure
4. Consider deprecation warnings: For major type renames, consider providing deprecated aliases temporarily

💡 Code Quality Notes

Positive aspects:

• Consistent use of zod for validation
• Good documentation in schema comments
• Proper environment variable fallbacks
• Clean separation of concerns

Minor suggestions:

• The .removeDefault() call in RunnerConfigSchema could benefit from a comment explaining why it's needed
• Consider extracting common environment variable patterns to reduce repetition

🔍 Specific File Reviews

• src/client/config.ts: Well-structured simplification ✅
• src/drivers/engine/config.ts: Good inheritance pattern, fix typo ⚠️
• src/registry/run-config.ts: Clean refactor with proper merging ✅
• src/utils.ts: Good centralization of shared types ✅

---

Verdict: Approve with minor fixes. The config simplification is well-executed and improves the codebase structure. Just fix the schema name typo and update any affected tests.

[NathanFlurry]

• chore(core): add support for auto-configuring serverless #1356 : 2 dependent PRs (#1352 , #1357 )
• chore(core): add build:fast script #1355
• feat(core): support running engine #1353
• fix(example-deno): fix check-types #1351
• chore(core): simplify config #1350 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• merge queue - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Claude finished @NathanFlurry's task —— View job

---

PR Review: Config Simplification

Reviewing this config simplification PR for code quality, potential issues, and best practices.

Review Tasks:

• Analyze core config changes in src/client/config.ts
• Review driver config changes in src/drivers/engine/config.ts
• Examine registry run config changes in src/registry/run-config.ts
• Check for breaking changes across modified files
• Assess security and performance implications
• Evaluate test coverage impact
• Provide comprehensive feedback

Issues Found

🚨 Critical: Typo in Schema Name

Location: src/drivers/engine/config.ts:5

export const EngingConfigSchema = z  // Should be "EngineConfigSchema"

This typo is propagated throughout the codebase and needs to be fixed. Found in:

• src/drivers/engine/config.ts:5, 21, 22
• src/drivers/engine/mod.ts:4, 7, 11
• src/registry/run-config.ts:7

⚠️ Potential Breaking Changes

1. Default Endpoint Change (src/client/config.ts:15)

   • Before: null (nullable)
   • After: "https://api.rivet.gg" (non-null with default)
   • Impact: Code expecting null values may break

2. Config Structure Changes

   • Removed api.host and api.port from ClientConfig
   • Removed pegboardEndpoint from EngineConfig
   • These appear to be unused based on the git diff, but could affect external consumers

3. Schema Name Changes

   • ConfigSchema → EngineConfigSchema (with typo)
   • RunConfigSchema → RunnerConfigSchema
   • Import paths and type references updated throughout

Positive Changes

✅ Good Architectural Improvements

1. Config Composition - Using .merge(ClientConfigSchema) in EngineConfig creates better separation of concerns
2. Consistent Environment Variable Handling - Consolidated getEnvUniversal() usage
3. Type Safety - Better TypeScript inference with cleaner input/output types
4. Documentation - Improved JSDoc comments for config fields

✅ Code Quality

1. Import Consolidation - Moving GetUpgradeWebSocket to utils and importing it consistently
2. Default Value Handling - More consistent use of Zod's .default() patterns
3. Removed Dead Code - Eliminated unused config fields and simplified structures

Security & Performance Assessment

🔒 Security: Good

• No sensitive data exposure issues found
• Environment variable handling remains secure
• Token handling unchanged and appropriate

⚡ Performance: Neutral

• Schema parsing overhead should be similar
• Default function calls are appropriately lazy
• No performance regressions expected

Test Coverage Impact

⚠️ Potential Test Issues

The test file tests/driver-engine.test.ts uses RunnerConfigSchema which was renamed from RunConfigSchema. However, the import was updated correctly, so tests should continue working.

Recommendation: Run the test suite to ensure no runtime issues from the config changes.

Recommendations

🔧 Must Fix

1. Fix typo: EngingConfigSchema → EngineConfigSchema throughout codebase
2. Document breaking changes in commit message or PR description
3. Consider migration guide if this is a public API

💡 Suggestions

1. Add validation for the new default endpoint URL format
2. Consider backward compatibility for the endpoint nullable → non-null change
3. Verify examples/tests work with new default endpoint

Summary

This is a solid refactoring that improves config organization and reduces duplication. The main concern is the typo in EngingConfigSchema that needs immediate fixing. The breaking changes around endpoint defaults should be documented for users.

Overall Assessment: ✅ Approve with fixes needed

---

[pkg-pr-new]

More templates

• example-ai-agent
• example-better-auth-external-db
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-counter
• example-crdt
• example-database
• example-deno
• example-sqlite
• example-elysia
• example-express
• example-game
• example-hono
• example-hono-react
• example-kitchen-sink
• example-next-js
• example-rate
• example-raw-fetch-handler
• example-raw-websocket-handler-proxy
• example-react
• starter
• example-stream
• example-sync
• example-tenant
• example-trpc

@rivetkit/actor

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/actor@1350

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/cloudflare-workers@1350

@rivetkit/core

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/core@1350

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/db@1350

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/framework-base@1350

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/next-js@1350

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/react@1350

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivetkit@1350

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivetkit/@rivetkit/sql-loader@1350

commit: c372f5f

[graphite-app]

There's a typo in the schema name EngingConfigSchema which should be EngineConfigSchema. This needs to be corrected for consistency with how it's referenced elsewhere in the codebase.

Suggested change

	export const EngingConfigSchema = z
	export const EngineConfigSchema = z

Spotted by Diamond



Is this helpful? React 👍 or 👎 to let us know.

[claude]

Claude finished @NathanFlurry's task —— View job

---

PR Review: Config Simplification

Reviewing this config simplification PR for code quality, potential issues, and best practices.

Review Tasks:

• Analyze core config changes in src/client/config.ts
• Review driver config changes in src/drivers/engine/config.ts
• Examine registry run config changes in src/registry/run-config.ts
• Check for breaking changes across modified files
• Assess security and performance implications
• Evaluate test coverage impact
• Provide comprehensive feedback

---

Issues Found

🚨 Critical: Typo in Schema Name

Location: src/drivers/engine/config.ts:5

export const EngingConfigSchema = z  // Should be "EngineConfigSchema"

This typo is propagated throughout the codebase and needs to be fixed. Found in:

• src/drivers/engine/config.ts:5, 21, 22
• src/drivers/engine/mod.ts:4, 7, 11
• src/registry/run-config.ts:7

⚠️ Potential Breaking Changes

1. Default Endpoint Change (src/client/config.ts:15)

   • Before: null (nullable)
   • After: "https://api.rivet.gg" (non-null with default)
   • Impact: Code expecting null values may break

2. Config Structure Changes

   • Removed api.host and api.port from ClientConfig
   • Removed pegboardEndpoint from EngineConfig
   • These appear to be unused based on the git diff, but could affect external consumers

3. Schema Name Changes

   • ConfigSchema → EngineConfigSchema (with typo)
   • RunConfigSchema → RunnerConfigSchema
   • Import paths and type references updated throughout

Positive Changes

✅ Good Architectural Improvements

1. Config Composition - Using .merge(ClientConfigSchema) in EngineConfig creates better separation of concerns
2. Consistent Environment Variable Handling - Consolidated getEnvUniversal() usage
3. Type Safety - Better TypeScript inference with cleaner input/output types
4. Documentation - Improved JSDoc comments for config fields

✅ Code Quality

1. Import Consolidation - Moving GetUpgradeWebSocket to utils and importing it consistently
2. Default Value Handling - More consistent use of Zod's .default() patterns
3. Removed Dead Code - Eliminated unused config fields and simplified structures

Security & Performance Assessment

🔒 Security: Good

• No sensitive data exposure issues found
• Environment variable handling remains secure
• Token handling unchanged and appropriate

⚡ Performance: Neutral

• Schema parsing overhead should be similar
• Default function calls are appropriately lazy
• No performance regressions expected

Test Coverage Impact

⚠️ Potential Test Issues

The test file tests/driver-engine.test.ts uses RunnerConfigSchema which was renamed from RunConfigSchema. However, the import was updated correctly, so tests should continue working.

Recommendation: Run the test suite to ensure no runtime issues from the config changes.

Recommendations

🔧 Must Fix

1. Fix typo: EngingConfigSchema → EngineConfigSchema throughout codebase
2. Document breaking changes in commit message or PR description
3. Consider migration guide if this is a public API

💡 Suggestions

1. Add validation for the new default endpoint URL format
2. Consider backward compatibility for the endpoint nullable → non-null change
3. Verify examples/tests work with new default endpoint

Summary

This is a solid refactoring that improves config organization and reduces duplication. The main concern is the typo in EngingConfigSchema that needs immediate fixing. The breaking changes around endpoint defaults should be documented for users.

Overall Assessment: ✅ Approve with fixes needed

---

[claude]

Claude finished @NathanFlurry's task —— View job

---

PR Review: Config Simplification

Reviewing this config simplification PR for code quality, potential issues, and best practices.

Review Tasks:

• Analyze core config changes in src/client/config.ts
• Review driver config changes in src/drivers/engine/config.ts
• Examine registry run config changes in src/registry/run-config.ts
• Check for breaking changes across modified files
• Assess security and performance implications
• Evaluate test coverage impact
• Provide comprehensive feedback

---

Issues Found

🚨 Critical: Typo in Schema Name

Location: src/drivers/engine/config.ts:5

export const EngingConfigSchema = z  // Should be "EngineConfigSchema"

This typo is propagated throughout the codebase and needs to be fixed. Found in:

• src/drivers/engine/config.ts:5, 21, 22
• src/drivers/engine/mod.ts:4, 7, 11
• src/registry/run-config.ts:7

⚠️ Potential Breaking Changes

1. Default Endpoint Change (src/client/config.ts:15)

   • Before: null (nullable)
   • After: "https://api.rivet.gg" (non-null with default)
   • Impact: Code expecting null values may break

2. Config Structure Changes

   • Removed api.host and api.port from ClientConfig
   • Removed pegboardEndpoint from EngineConfig
   • These appear to be unused based on the git diff, but could affect external consumers

3. Schema Name Changes

   • ConfigSchema → EngineConfigSchema (with typo)
   • RunConfigSchema → RunnerConfigSchema
   • Import paths and type references updated throughout

Positive Changes

✅ Good Architectural Improvements

1. Config Composition - Using .merge(ClientConfigSchema) in EngineConfig creates better separation of concerns
2. Consistent Environment Variable Handling - Consolidated getEnvUniversal() usage
3. Type Safety - Better TypeScript inference with cleaner input/output types
4. Documentation - Improved JSDoc comments for config fields

✅ Code Quality

1. Import Consolidation - Moving GetUpgradeWebSocket to utils and importing it consistently
2. Default Value Handling - More consistent use of Zod's .default() patterns
3. Removed Dead Code - Eliminated unused config fields and simplified structures

Security & Performance Assessment

🔒 Security: Good

• No sensitive data exposure issues found
• Environment variable handling remains secure
• Token handling unchanged and appropriate

⚡ Performance: Neutral

• Schema parsing overhead should be similar
• Default function calls are appropriately lazy
• No performance regressions expected

Test Coverage Impact

⚠️ Potential Test Issues

The test file tests/driver-engine.test.ts uses RunnerConfigSchema which was renamed from RunConfigSchema. However, the import was updated correctly, so tests should continue working.

Recommendation: Run the test suite to ensure no runtime issues from the config changes.

Recommendations

🔧 Must Fix

1. Fix typo: EngingConfigSchema → EngineConfigSchema throughout codebase
2. Document breaking changes in commit message or PR description
3. Consider migration guide if this is a public API

💡 Suggestions

1. Add validation for the new default endpoint URL format
2. Consider backward compatibility for the endpoint nullable → non-null change
3. Verify examples/tests work with new default endpoint

Summary

This is a solid refactoring that improves config organization and reduces duplication. The main concern is the typo in EngingConfigSchema that needs immediate fixing. The breaking changes around endpoint defaults should be documented for users.

Overall Assessment: ✅ Approve with fixes needed

---

[graphite-app]

Merge activity

• Oct 6, 7:40 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
• Oct 6, 7:41 PM UTC: CI is running for this pull request on a draft pull request (#1360) due to your merge queue CI optimization settings.
• Oct 6, 7:42 PM UTC: Merged by the Graphite merge queue via draft PR: #1360.