[pull] main from rabbitmq:main #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Golang 1.19 is no longer supported. Usa oldstable and stable aliases Since actions/setup-go v3, we can use oldstable and stable aliases to always refer to the two latest supported versions of Go. Signed-off-by: Aitor Perez Cedres <[email protected]>
Change the time comparison to use Equal, which is safer with timestamps in go. Use IsZero()
Use isZero to check if a Time instance is initialized
Closes 222
Fix up a go lint error with no space between the // and the text.
skip-checks:true
Bumps [go.uber.org/goleak](https://github.com/uber-go/goleak) from 1.2.1 to 1.3.0. - [Release notes](https://github.com/uber-go/goleak/releases) - [Changelog](https://github.com/uber-go/goleak/blob/master/CHANGELOG.md) - [Commits](uber-go/goleak@v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: go.uber.org/goleak dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…rg/goleak-1.3.0 Bump go.uber.org/goleak from 1.2.1 to 1.3.0
fix comment typo in example_client_test.go
- adds documentation that describes how the Expiration field should be used - provides two constants for the most presumable pitfalls
Documenting Publishing.Expiration usage
[skip ci] Signed-off-by: Aitor Perez Cedres <[email protected]>
Use correct mutex to guard confirms.published
Example fix
Small fixes and refactors
chore: doc typo
Add test that demonstrates the issue
…mproved performance
This error can happen when a Delivery (message) is ack/nack/reject after the AMQP channel is closed, and the consuming function/routine does not check the status of Go receive operation.
Expose delivery not initialised error
fix: unify receiver methods to avoid conflicts between value and pointer types
Add warning about concurrency with Channels
Methods UnsafePush and Consume returns errNotConnected in the same conditions
Return existing error instead of creating new for the same purpose
Write test that demonstrates issue with using `Qos` and async workers.
Investigate GH-296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )