JSDec as cutter native plugin #3304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
wargio
force-pushed
the
fix-jsdec
branch
4 times, most recently
from
40d6d84 to
d3f3c3a
Compare
XVilka
approved these changes
Feb 25, 2024
| @@ -286,6 +287,7 @@ void CutterCore::loadDefaultCutterRC() | |||
| } | |||
| qInfo() << tr("Loading initialization file from ") << cutterRCFilePath; | |||
| rz_core_cmd_file(core, cutterRCFilePath.toUtf8().constData()); | |||
| rz_cons_flush(); | |||
| } | |||
|
|
|||
| QList<QString> CutterCore::sdbList(QString path) | |||
There was a problem hiding this comment.
We should remove this function in the future.
There was a problem hiding this comment.
there are many thing that should be rewritten in cutter to simplify stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Builds jsdec as a cutter native plugin.
Fix #3303