Fix multiple crashes related to incorrect rz_iterator usage.

[karliss]

RzAnalysisBytes are owned by the iterator, so returning analysis bytes while destroying iterator owning it is incorrect.

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've updated the documentation with the relevant information (if needed)

Detailed description

RzAnalysisBytes are owned by the iterator, so returning analysis bytes while destroying iterator owning it is incorrect. Previous version could cause use after free or attempts to free struct which shouldn't freed crashing either way.

Easiest methods to trigger the crash was opening right click context menu in disassembly or graph. And opening xrefs window on instruction with code xrefs (like the start of function). There might be others getRzAnalysisBytesSingle is indirectly used by quite a few places.

I am not too happy about the RzIter wrapper. But since it's already there I was thinking I could replace some of the places currently dealing with RzAnalysisBytes to use RzAnalysisOp instead, but not in this pull request.

Seems like 8574f0b is also included in v2.3.3 so there is a high chance that it is mostly unusable due to right click crash.

Test plan (required)

• right click in disassembly panel -> shouldn't crash
• right click in function graph -> shouldn't crash
• click on function start and open xrefs window -> shouldn't crash

Closing issues

[XVilka]

Thanks, my bad for the wrong implementation at the first place. Yes, we should make a new patch release including this fix along with couple fixes in Rizin once this is merged.