Allow packagers to manually override CUTTER_VERSION_FULL

[Integral-Tech]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've updated the documentation with the relevant information (if needed)

Detailed description

The git revision check doesn't always work. For example, when building cutter as an Arch Linux package (namely extra/rz-cutter in the Arch Linux repository), the CUTTER_VERSION_FULL is set to a strange value:

Therefore we should allow packages to manually override CUTTER_VERSION_FULL.

Test plan (required)

• Use -DCUTTER_VERSION_FULL=<version> in cmake command to test changes.

Before:

After:

Closing issues

[karliss]

Marking whole version string variable might have bad sideeffects for user/developer builds where user keeps updating local copy. I will do some tests.

I am guessing that Arch is getting wrong commit hash due to build recipe also being stored in git and the command used by build script picking wrong one. Might be worth looking into fixing that, but that's a separate issue. Having a version override would be still useful.

@Integral-Tech What if only the suffix part was overridable? Would that be sufficient for package maintainer needs ?

Seems like in your example you set the version to plain "2.3.4" in that case it should have been already possible to achieve similar result by setting "GIT_REV" to empty string which should use the other branch of if which doesn't have any git stuff.

I can imagine that there would still be value for some override so that packagers can better communicate presence of distro specific customizations or build number.

[Integral-Tech]

@karliss

What if only the suffix part was overridable?

You mean in the following CUTTER_VERSION_FULL,

set(CUTTER_VERSION_FULL "${CUTTER_VERSION}-${GIT_BRANCH}-${GIT_REV}")

Only make GIT_BRANCH and GIT_REV overridable?
I don't think that makes sense, as two hyphens will still be left in CUTTER_VERSION_FULL if we set GIT_BRANCH and GIT_REV to empty string.

[karliss]

Sorry didn't saw where the GIT_REV comes from and misunderstood the intention of if (${GIT_REV}" STREQUAL "") thinking it's already there for being able to disable it by user. Turns out it's only there as fallback and can't be currently set by user.

Anyway the idea was something like this

set(CUTTER_VERSION_SUFFIX "" CACHE STRING)
if (DISABLE_GIT_VERSION OR  "${GIT_REV}" STREQUAL "")
    set(CUTTER_VERSION_FULL "${CUTTER_VERSION}${CUTTER_VERSION_SUFFIX}")
else()
    ... # existing code for getting GIT version
    set(CUTTER_VERSION_FULL ""  STRING "${CUTTER_VERSION}${CUTTER_VERSION_SUFFIX}-${GIT_BRANCH}-${GIT_REV}")
endif()

[karliss]

Created a new PR #3422 with the approach I described. It should better deal with user/dev builds, while hopefully addressing the main problem you created this PR.

[Integral-Tech]

@karliss If you'd like to merge pull request #3422, can I close this one?

[karliss]

Closed in favor of #3422 .