-
Notifications
You must be signed in to change notification settings - Fork 0
Finalize HTTP gateway token wiring for single-package layout #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: repo-restructure
Are you sure you want to change the base?
Finalize HTTP gateway token wiring for single-package layout #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| "dependencies": { | ||
| "@mew-protocol/agent": "^0.4.1" | ||
| "@mew-protocol/mew/agent": "^0.4.1" | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Replace subpath dependency with published package
The scenario template now declares a dependency on "@mew-protocol/mew/agent", but npm dependencies must reference published packages, not subpath exports. No package with that name exists, so npm install for the template will fail with “No matching version found for @mew-protocol/mew/agent”. Installers should depend on @mew-protocol/mew and import from @mew-protocol/mew/agent at runtime.
Useful? React with 👍 / 👎.
| "dependencies": { | ||
| "@mew-protocol/agent": "^0.4.1", | ||
| "@mew-protocol/mew/agent": "^0.4.1", | ||
| "ws": "^8.18.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Use root MEW package in proposals scenario dependencies
The package manifest now lists "@mew-protocol/mew/agent" as a dependency. Because that subpath is not a publishable npm package, npm install in this scenario workspace will fail, preventing the TypeScript proposals scenario from running. The dependency should remain on @mew-protocol/mew and the code should import from @mew-protocol/mew/agent instead.
Useful? React with 👍 / 👎.
| "dependencies": { | ||
| "@mew-protocol/participant": "^0.2.0", | ||
| "@mew-protocol/mew/participant": "^0.2.0", | ||
| "ws": "^8.18.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Fix participant dependency to target published package
The multi-agent scenario now depends on "@mew-protocol/mew/participant". Npm will treat that as a separate package which is not published, causing dependency installation to fail. To resolve, depend on @mew-protocol/mew and import the participant module via @mew-protocol/mew/participant at runtime.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68da8deb346c83258ba0c74f017b927f