refactor to use stdio #5
Conversation
rjcorwin
commented
Sep 19, 2025
rjcorwin
commented
- Token ignore in test scenarios
- codex up to scenario 9
- codex on scenario 12
- All tests pass
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
cli/src/gateway/core.js
Outdated
| _handleIncomingEnvelope(participantId, envelope, channel) { | ||
| const connection = this.connections.get(participantId); | ||
|
|
||
| if (!connection) { | ||
| this._handleJoin(participantId, envelope, channel); | ||
| return; | ||
| } | ||
|
|
||
| // Subsequent messages: enforce space and from fields before routing | ||
| const enrichedEnvelope = { | ||
| ...envelope, | ||
| space: this.spaceId, | ||
| from: participantId, | ||
| protocol: envelope.protocol || 'mew/v0.3', | ||
| ts: envelope.ts || new Date().toISOString(), | ||
| }; | ||
|
|
||
| this._broadcast(enrichedEnvelope, { exclude: participantId }); |
There was a problem hiding this comment.
[P1] Stop forwarding sender's messages to sender
The new gateway core calls _broadcast(enrichedEnvelope, { exclude: participantId }), which means the originator no longer receives its own envelopes. The previous implementation explicitly broadcast every message to all participants to satisfy protocol semantics (participants rely on seeing their own messages for correlation and state updates). With this exclusion, any agent that emits a message will never observe it locally, breaking existing behaviour and contradicting the documented requirement that messages are visible to everyone. Drop the exclusion or reintroduce a self-delivery for the sender.
Useful? React with 👍 / 👎.
