Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daisyui #4495

Closed
wants to merge 3 commits into from
Closed

Daisyui #4495

wants to merge 3 commits into from

Conversation

inchoate
Copy link

Reasons for making this change

[Please describe them here]

If this is related to existing tickets, include links to them as well. Use the syntax fixes #[issue number] (ex: fixes #123).

If your PR is non-trivial and you'd like to schedule a synchronous review, please add it to the weekly meeting agenda: https://docs.google.com/document/d/12PjTvv21k6LIky6bNQVnsplMLLnmEuypTLQF8a-8Wss/edit

Checklist

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests. I've run npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:update to update snapshots, if needed.
    • I've updated docs if needed
    • I've updated the changelog with a description of the PR
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@inchoate
Copy link
Author

This PR supersedes my previous attempt, now that I know a little more about the project.

This PR adds:

  • DaisyUI v5 (beta)
  • Equivalently working playground (Custom Arrays is still broken for everyone)
  • all of Daisy's subthemes work

Notes

  • I'll come back and remove the console.logs if this PR gets traction.

Some screenshots:

Themes
Screenshot 2025-02-13 at 5 36 58 PM

Sub-themes
Screenshot 2025-02-13 at 5 37 11 PM

Sample Compliant Renders
Screenshot 2025-02-13 at 5 37 39 PM

Screenshot 2025-02-13 at 5 37 29 PM Screenshot 2025-02-13 at 5 37 58 PM

Integrated react-day-picker
Screenshot 2025-02-13 at 5 39 34 PM

@jasny
Copy link

jasny commented Feb 14, 2025

@inchoate No new features will be accepted to version 5. Please make a PR for version 6 instead, which currently is in alpha.

(I'm working on the primereact theme #4497 and was asked to do the same)

@inchoate
Copy link
Author

@inchoate No new features will be accepted to version 5. Please make a PR for version 6 instead, which currently is in alpha.

(I'm working on the primereact theme #4497 and was asked to do the same)

🤦 I wish I knew before starting days of work. No mention on the contributing docs, either? At this point, as much as I love the idea of this project, I might have to abandon this work.

@inchoate inchoate closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants