Added ability to search for tickets by event_id - #1
Open
eewang wants to merge 2 commits into
Open
Conversation
Owner
|
Hi, thanks for the pull request. A couple things:
please feel free to rework your pull request accordingly |
|
I think eewang is on the right track though, you will want a way to get tickets for an event_id that is known without having to do two separate requests. The way I approached it in my pull request was by giving every class a ::find method that lets you build a query from scratch. And when you look at the syntax, I think it's pretty clear what's going on when you call: Ticket.find(:event_id => 12345) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.