Skip to content

chore: Bump Go version to 1.24 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2025
Merged

chore: Bump Go version to 1.24 #60

merged 1 commit into from
May 24, 2025

Conversation

rm3l
Copy link
Owner

@rm3l rm3l commented May 24, 2025

Summary by Sourcery

Upgrade Go toolchain to 1.24, update CI linting action, and suppress unhandled error warnings.

Enhancements:

  • Ignore fmt.Fprintln error return to satisfy linter

Build:

  • Bump module Go version to 1.24

CI:

  • Update golangci-lint GitHub Action to v8

Chores:

  • Regenerate go.sum and update .tool-versions

Copy link

sourcery-ai bot commented May 24, 2025

Reviewer's Guide

This PR upgrades the project’s Go version to 1.24, bumps the golangci-lint action to v8, adjusts error handling in the GitHub issue finder, and refreshes related version files.

File-Level Changes

Change Details Files
Ignore fmt.Fprintln return values when writing stderr
  • Replaced direct fmt.Fprintln call with assignment to blank identifiers
pkg/issue/github.go
Upgrade golangci-lint GitHub Action
  • Changed action reference from v6.5.2 to v8
.github/workflows/lint.yml
Bump Go version in module definition
  • Updated go directive from 1.20 to 1.24
go.mod
Refresh tooling and checksum files
  • Regenerated entries in .tool-versions
  • Updated go.sum with new module checksums
.tool-versions
go.sum

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@rm3l rm3l merged commit ada33ed into main May 24, 2025
3 checks passed
@rm3l rm3l deleted the bump_go_1.24 branch May 24, 2025 09:16
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rm3l - I've reviewed your changes - here's some feedback:

  • Double-check that upgrading golangci-lint-action to v8 still supports the version input syntax used here, as v8 may have breaking config changes.
  • Since you’re intentionally ignoring the error returned by fmt.Fprintln, consider adding a brief comment explaining why it’s safe to discard it rather than silently swallowing failures.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant