Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve ambiguous expression issue introduced in Xcode 16 #3562

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

decomoraes
Copy link
Contributor

Description

Fixes the issue where ‘Expression’ is ambiguous for type lookup in Xcode 16. This resolves compilation errors related to ‘Expression’ type ambiguities in RNMBXLayer, RNMBXStyleValue, and other affected components.

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Screenshot 2024-07-01 at 19 39 42

Component to reproduce the issue you're fixing

Run the RNMapbox in Xcode 16

@decomoraes decomoraes temporarily deployed to CI with Mapbox Tokens July 1, 2024 23:32 — with GitHub Actions Inactive
@decomoraes decomoraes temporarily deployed to CI with Mapbox Tokens July 1, 2024 23:32 — with GitHub Actions Inactive
@decomoraes decomoraes temporarily deployed to CI with Mapbox Tokens July 1, 2024 23:32 — with GitHub Actions Inactive
@decomoraes decomoraes temporarily deployed to CI with Mapbox Tokens July 1, 2024 23:32 — with GitHub Actions Inactive
@decomoraes decomoraes temporarily deployed to CI with Mapbox Tokens July 1, 2024 23:32 — with GitHub Actions Inactive
@decomoraes decomoraes temporarily deployed to CI with Mapbox Tokens July 1, 2024 23:32 — with GitHub Actions Inactive
@decomoraes decomoraes temporarily deployed to CI with Mapbox Tokens July 1, 2024 23:32 — with GitHub Actions Inactive
@mfazekas mfazekas merged commit 0c37ee8 into rnmapbox:main Jul 3, 2024
11 checks passed
@mfazekas
Copy link
Contributor

mfazekas commented Jul 3, 2024

@decomoraes thanks much for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants