Skip to content

Fix for incorrect line terminators in partials on Windows - #30

Open
yasniy wants to merge 2 commits into
robertknight:masterfrom
yasniy:master
Open

Fix for incorrect line terminators in partials on Windows#30
yasniy wants to merge 2 commits into
robertknight:masterfrom
yasniy:master

Conversation

@yasniy

@yasniy yasniy commented Jan 27, 2020

Copy link
Copy Markdown

When the partial file contains Windows-slyle line terminators ("\r\n") it will not be converted into normal C-slyle "\n" for internal use. As a result the rendered file saved as text will have a broked line terminator "\r\r\n".

@robertknight

robertknight commented Jan 28, 2020

Copy link
Copy Markdown
Owner

Hello,

The change looks fine but can you add a test to check for the issue you fixed? There is one Qt 5 test that is failing but it looks like that is unrelated to the change you made.

@yasniy

yasniy commented Jan 28, 2020

Copy link
Copy Markdown
Author

Test fails due to the way Qt 5.5 used in test handles double to string conversion. This behaviour was changed in Qt 5.7: "Added support for converting a floating point to its shortest and exact string form, without having to pre-calculate the number of digits." (What's New in Qt 5.7)

@robertknight

Copy link
Copy Markdown
Owner

I rebased on the master branch which now has CI set up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants